-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base-profiles: supports profiles with limited/no command usage #290
base: master
Are you sure you want to change the base?
Conversation
26edf1e
to
e65e800
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #290 +/- ##
==========================================
- Coverage 69.88% 69.71% -0.16%
==========================================
Files 118 119 +1
Lines 11891 12018 +127
==========================================
+ Hits 8309 8378 +69
- Misses 3193 3243 +50
- Partials 389 397 +8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
e65e800
to
1a82716
Compare
1a82716
to
fd342c8
Compare
@creativeprojects, the PR is updated to include command filter (& base-profile) support in Note: I've removed the comment that V2 configs will disallow inline schedules since I think this limitation isn't required. After all inline schedules are the only option to inherit configs and base-profiles make it possible to do so without side effects. |
hmmm true; do we still need a separate schedule section after all? because we could allow the same schedule section to groups, as this was the missing piece basically. |
or maybe just moving all |
Converting inline schedules to subsection would likely make it appear a bit nicer in yaml. For toml it may be less intuitive and we'd probably need to support both ways. Well I think a separate schedule section does make sense as the runtime behaviour differs. Inline schedules all run individually, but the schedule section runs as a single item. No sure if that can be fully implemented with groups in a way that is easier. It may work for groups if it uses multiple |
@creativeprojects , had just drafted how a unified |
Implements #282
Waiting on #259 before completing itRelated updates in command completion will come separately