-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Global json schema (auto versioning) #195
Conversation
This simplifies the schema and makes it more compatible (config-1)
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #195 +/- ##
==========================================
+ Coverage 76.02% 76.05% +0.04%
==========================================
Files 93 93
Lines 9777 9784 +7
==========================================
+ Hits 7432 7441 +9
Misses 2086 2086
+ Partials 259 257 -2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
91638dd
to
e38130c
Compare
e38130c
to
d458c2f
Compare
After some adjustments it works well for YAML and JSON now. "Even better TOML" doesn't support One improvement for "Even better TOML" however is that the updated version-1 schema now also works correctly. Previously it didn't support profile commands due to the lack of full regex support in the editor plugin. For testing with local references, run:
Auto selection then works with: # yaml-language-server: $schema=http://localhost:1313/resticprofile/jsonschema/config.json
version: "2"
global:
restic-version: "0.15"
|
Might be due to implication. While most examples indicate that it should be fine to use it for versioning, I think it needs to be updated to select all versions first using Will update the template. |
MR too old to rebase, replaced by #412 |
This PR:
version
andglobal.restic-version
properties (see also SchemaStore).generate --config-reference filename
additionalProperties
instead of via regex matching with negative lookbehind)The is the first step to add the schema to the schemastore catalog (we need a single schema for this) and is also more convenient if the URL doesn't need to be changed 😀