Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Custom Inline Error Message for Empty Search Field #314

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

SylviaUzoh1
Copy link
Contributor

@SylviaUzoh1 SylviaUzoh1 commented Oct 24, 2024

Fixes

Description

This pull request addresses the issue where an empty search field caused the browser to display a native modal message that was inconsistent with the site's user experience. Instead of relying on the browser's default behavior, this PR introduces a custom inline error message to guide users to enter a search term in a more visually consistent and user-friendly manner.

Technical details

  • JavaScript: Added a script that listens for the "Search" button click and search field input change. It checks if the search field is empty and displays a custom error message if needed. This prevents the default modal popup from the browser.
  • HTML: Included a
    below the search field to display the error message when triggered.
  • CSS: Styled the error message to match the site’s color scheme and typography for a seamless visual experience.

Tests

  • Open the search page and leave the search field empty.
  • Click the "Search" button and confirm that an error message appears below the search field saying "Please enter a search term." The input field is highlighted to draw attention.
  • Enter a search term and verify that the error message disappears and the form is submitted correctly.
  • Verify that no native browser alerts appear when clicking the "Search" button.

Screenshots

Before:
Screenshot (308)
Screenshot (307)

After:
Screenshot (310)
Screenshot (309)

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main or master).
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

For the purposes of this DCO, "license" is equivalent to "license or public domain dedication," and "open source license" is equivalent to "open content license or public domain dedication."

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@SylviaUzoh1 SylviaUzoh1 requested a review from a team as a code owner October 24, 2024 14:35
@SylviaUzoh1 SylviaUzoh1 requested review from TimidRobot and Shafiya-Heena and removed request for a team October 24, 2024 14:35
Copy link

netlify bot commented Oct 24, 2024

Deploy Preview for cc-search-portal ready!

Name Link
🔨 Latest commit fc1006d
🔍 Latest deploy log https://app.netlify.com/sites/cc-search-portal/deploys/6720aadfaf40f60008f9d70c
😎 Deploy Preview https://deploy-preview-314--cc-search-portal.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@possumbilities
Copy link
Contributor

@SylviaUzoh1 this is looking good so far! the message itself should display for the input on all screen sizes, not just smaller sizes. Was there a reason you only included it on smaller screen sizes?

@SylviaUzoh1
Copy link
Contributor Author

@SylviaUzoh1 this is looking good so far! the message itself should display for the input on all screen sizes, not just smaller sizes. Was there a reason you only included it on smaller screen sizes?

@possumbilities, the initial implementation targeted smaller screens to keep the error message close to the input field. I've now updated it to display across all screen sizes for consistency and a better user experience.

Let me know if there's anything else you'd like me to adjust!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In review
Development

Successfully merging this pull request may close these issues.

[Feature] Custom Notification for Empty Search Field Instead of Browser's Native Modal
3 participants