Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ccMixter search incorrect data response resolved #285

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

SisiVero
Copy link
Contributor

@SisiVero SisiVero commented Oct 10, 2024

Fixes

Description

Issue:
An error was encountered when attempting to include zero as a license type in the rights variable for queries to the ccMixter API. The query string that included zero resulted in an invalid request, leading to an error response from the API.

Cause:
The ccMixter API does not recognize zero as a valid license type in its query format. As zero was causing the error, the issue was identified to be a misrepresentation of the license type.

Solution:
To resolve this issue, I replaced zero with cc0 in the query string. The updated code now correctly handles the public domain license type, avoiding any query errors.

Changes made:

  1. Replaced zero with cc0 to properly represent the public domain license type.
  2. Ensured that the query string is formatted correctly for the ccMixter API.

Tests

  1. After updating the license type in the query string, I tested the API request to verify that the error was resolved and the
    request was successful.
  2. The API now responds correctly with the expected results when cc0 is used instead of zero.

Screenshots

workingCCmixter

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main or master).
  • My commit messages follow [best practices][best_practices].
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

@SisiVero SisiVero requested a review from a team as a code owner October 10, 2024 09:58
@SisiVero SisiVero requested review from TimidRobot and possumbilities and removed request for a team October 10, 2024 09:58
Copy link

netlify bot commented Oct 10, 2024

Deploy Preview for cc-search-portal ready!

Name Link
🔨 Latest commit 25b7f7f
🔍 Latest deploy log https://app.netlify.com/sites/cc-search-portal/deploys/670f8dc063b33a0008510966
😎 Deploy Preview https://deploy-preview-285--cc-search-portal.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In review
Development

Successfully merging this pull request may close these issues.

[Bug] Searching using CCMixter shows incorrect data
1 participant