Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabled buttons hover reaction #249

Closed
wants to merge 1 commit into from
Closed

Conversation

Macomi27
Copy link
Contributor

@Macomi27 Macomi27 commented Oct 5, 2024

Fixes

Description

Technical details

Tests

Screenshots

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main or master).
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

For the purposes of this DCO, "license" is equivalent to "license or public domain dedication," and "open source license" is equivalent to "open content license or public domain dedication."

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@Macomi27 Macomi27 requested a review from a team as a code owner October 5, 2024 07:57
@Macomi27 Macomi27 requested review from TimidRobot and possumbilities and removed request for a team October 5, 2024 07:57
Copy link

netlify bot commented Oct 5, 2024

Deploy Preview for cc-search-portal ready!

Name Link
🔨 Latest commit 90a2c18
🔍 Latest deploy log https://app.netlify.com/sites/cc-search-portal/deploys/6700f1739ef9340008249f4e
😎 Deploy Preview https://deploy-preview-249--cc-search-portal.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@@ -371,6 +373,7 @@ button.expand-menu {
border: none;
border-bottom-right-radius: 5px;
border-bottom-left-radius: 5px;
font-weight: 500;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to be a change not related to :hover

@@ -298,6 +298,8 @@ button.expand-menu {

.ancilliary-menu ul li button:hover {
cursor: pointer;
background-color: #FBE9E7;
color: #000;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes cannot be made directly to vocabulary.css in downstream projects, and should instead be made as override styles within the local style.css file.

@possumbilities
Copy link
Contributor

Hi! and thanks for this contribution! The color choices here do not satisfy appropriate Usability or Accessibility standards.

Changes to the buttons in the content area make sense here in this project, but adding hover behavior to the header would be better within the main Vocabulary repository so that it could affect downstream projects more consistently.

@possumbilities
Copy link
Contributor

Hi, and thank you for doing this work. After further review the Issue in question here as moved to 🚧 status: blocked Blocked & therefore, not ready for work so I'm closing this PR for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[Feature] Buttons Lack Hover Reactions - Poor User Experience
2 participants