-
-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enabled buttons hover reaction #249
Conversation
✅ Deploy Preview for cc-search-portal ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@@ -371,6 +373,7 @@ button.expand-menu { | |||
border: none; | |||
border-bottom-right-radius: 5px; | |||
border-bottom-left-radius: 5px; | |||
font-weight: 500; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems to be a change not related to :hover
@@ -298,6 +298,8 @@ button.expand-menu { | |||
|
|||
.ancilliary-menu ul li button:hover { | |||
cursor: pointer; | |||
background-color: #FBE9E7; | |||
color: #000; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changes cannot be made directly to vocabulary.css
in downstream projects, and should instead be made as override styles within the local style.css
file.
Hi! and thanks for this contribution! The color choices here do not satisfy appropriate Usability or Accessibility standards. Changes to the buttons in the content area make sense here in this project, but adding hover behavior to the header would be better within the main Vocabulary repository so that it could affect downstream projects more consistently. |
Hi, and thank you for doing this work. After further review the Issue in question here as moved to
🚧 status: blocked
|
Fixes
Description
Technical details
Tests
Screenshots
Checklist
Update index.md
).main
ormaster
).visible errors.
Developer Certificate of Origin
For the purposes of this DCO, "license" is equivalent to "license or public domain dedication," and "open source license" is equivalent to "open content license or public domain dedication."
Developer Certificate of Origin