add GitHub action that use Testing Farm #4320
Conversation
|
Skipping CI for Draft Pull Request. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
lilyLuLiu
force-pushed
the
main
branch
18 times, most recently
from
44eb1cf
to
bd41140
Compare
.github/workflows/linux-qe.yml
Outdated
| path: | | ||
| **/*.xml | ||
| **/*.results | ||
| **/*.log |
There was a problem hiding this comment.
After reserve, there is no need for decommission the testing farm machine (the target one for arm I mean)
|
I need to log in to the self-host runner to do some debug. So need to add my ssh public key into the github self-host runner from the testing farm. Waitting for https://gitlab.com/testing-farm/infrastructure/-/merge_requests/698 to be merged now. |
|
@adrianriobo Hi, I'm debugging run crc tests with machine from TestingFarm. The issue is, we can only use the self-host runner(also from TestingFarm) to provision and connect to the arm64 machine from TestingFarm. That means we can't connect to the machine with a container(deliverset image). So I think we can't use the container method to run crc tests with Testing Farm. |
|
@lilyLuLiu: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
| with: | ||
| name: linux-binary | ||
| path: "out/linux-arm64/crc" | ||
| build-qe: |
There was a problem hiding this comment.
I would prefer not having this specific flow. Currently we have the [Build Windows artifacts] where windows bits are built and also the qe images, may we can rename it to just builder and add there the linux builds.
Take into account if Linux bits are already build / check in some other flow remove it from there. The goal should be build only once.... otherwise if in future the build process requires something else on any element we need to be aware they are being built in several places with several goals.
|
|
||
| on: | ||
| workflow_run: | ||
| workflows: [Build Windows artifacts] |
There was a problem hiding this comment.
THis is aligned with previous comment if you create the unified builder flow this should be triggered for the new builder flow
|
|
||
| jobs: | ||
| tests: | ||
| runs-on: [self-hosted, linux, testing-farm] |
There was a problem hiding this comment.
Similar to ci-definitions for crc-builder we want to ensure the previous flow has been completed and it is successful https://github.com/crc-org/ci-definitions/blob/7cb907719aef4898ef4eb0ec02d9124f5212d9d4/.github/workflows/crc-builder-pusher.yml#L12
| go: ['1.21'] | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| - name: Set up Go |
There was a problem hiding this comment.
Why do we need go here? all components should be picked from as artifacts
| cd ${{ env.commit_sha }} | ||
|
|
||
| #timestamp=`date +%s` | ||
| #mkdir $timestamp |
There was a problem hiding this comment.
Can we clean comments (unused lines)
| run: | | ||
| echo "${PULL_SECRET}" > pull-secret | ||
| export TESTING_FARM_API_TOKEN=${TESTING_FARM_API_TOKEN} | ||
| #export TESTING_FARM_API_TOKEN=4a7ba1e1-3881-4bf8-9543-b3521b4fed17 |
There was a problem hiding this comment.
I guess this token has been reverted. The new one I guess it is already set on upstream crc repo right?
|
|
||
| - name: prepare env | ||
| run: | | ||
| sudo yum install podman openssh-server git make -y |
There was a problem hiding this comment.
Do we need git and make for any reason?
| echo $SSH_AGENT_PID > ssh_agent_pid | ||
| #kill $(cat ssh_agent_pid) | ||
| ssh-add id_rsa | ||
|
|
There was a problem hiding this comment.
We will need api invoke to add this as check for the PR
crc/.github/workflows/windows-qe-tpl.yml
Line 84 in 0342835
| # run | ||
| cmd="crc-qe/run.sh -junitFilename crc-e2e-junit.xml -targetFolder crc-qe" | ||
| cmd_microshift="${cmd} -e2eTagExpression '@story_microshift'" | ||
| cmd_openshift="${cmd} -e2eTagExpression '~@minimal && ~@story_microshift'" |
There was a problem hiding this comment.
Here you created both microshift and openshift diffferent commands.... but you are only running the openshift .. do we have any restriction on the number of machines we can provision? otherwise may you could create a tpl similar to this https://github.com/crc-org/crc/blob/main/.github/workflows/windows-qe-tpl.yml which would be executed on the self hosted runner the template typically provision a machine install crc run e2e and communicate with gh api to add checks on the PR.
With this approach you can run both in parallel each of them on a machine
| **/*.xml | ||
| **/*.results | ||
| **/*.log | ||
|
|
There was a problem hiding this comment.
It is not required to decommission the provisioned machine? May not but I guess it would be a good practice to reduce cost on their end?
#4326