Use SSE to track CRC status change and logs #192

evidolob · 2023-11-20T13:16:38Z

PR adds usage new SSE channels for tracking CRC status change and receiving logs.

jeffmaury · 2023-12-07T08:36:22Z

src/log-provider.ts

-    }, 3000);
+    const crcVersion = await getCrcVersion();
+    if (!crcVersion) {
+      console.warn("Can't get CRC CLI version, ignore getting daemons logs...");


Suggested change

console.warn("Can't get CRC CLI version, ignore getting daemons logs...");

console.warn('Can't get CRC CLI version, ignore getting daemons logs...');

gbraad · 2023-12-07T08:53:29Z

LOL, I just re-requested, while you had just reviewed. Sorry.

Just wanted to make sure you had seen this.
We are in the process of adding this to the CRC daemon.

src/constants.ts

src/crc-delete.ts

src/crc-status.ts

src/daemon-commander.ts

jeffmaury

I had CRC being stopped: when I launched Podman Desktop, I have this:

Is this expected that I can not start CRC from this screen ?

gbraad · 2023-12-07T09:12:58Z

src/events/eventsource.ts

+    let discardTrailingNewline = false;
+
+    req.on('data', chunk => {
+      if (!buf) {


a lot of processing to handle the end (linefeed) of a message. Can this be extracted and tested separately? At the moment, this looks more like implied knowledge.

src/extension.ts

src/preferences.ts

src/types.ts

gbraad · 2023-12-07T09:21:23Z

src/events/eventsource.ts

+
+        if (lineLength < 0) {
+          startingPos = length - pos;
+          startingFieldLength = fieldLength;


in this case it is a field, right?

can we therefore parse this as:

this.parseEventStreamField(buf, pos, fieldLength) ?

And the other case as:

this.parseEventStreamLine(buf, pos, lineLength); ?

If seems now to rely on a singe function with another check. This looks more complex than it needs to be.

That is for case when we don't receive 'full' line, as it is not guaranty that we will have whole line
so we just make sure that we have a complete line before parse it.

evidolob · 2023-12-07T14:18:02Z

@jeffmaury Have you use CRC from crc-org/crc#3903 PR?
As status change events is not merged in CRC yet, so you need to build CRC from that PR.

The reason why you may have error with latest CRC is because of this PR was check for wrong version - #192 (comment)

Signed-off-by: Yevhen Vydolob <[email protected]>

evidolob requested a review from gbraad November 20, 2023 13:16

evidolob force-pushed the add-sse branch from e51d050 to 1143d32 Compare November 20, 2023 13:18

evidolob requested a review from jeffmaury November 24, 2023 09:12

jeffmaury reviewed Dec 7, 2023

View reviewed changes

gbraad requested a review from jeffmaury December 7, 2023 08:52