Skip to content

Conversation

@anjannath
Copy link
Member

@anjannath anjannath commented Dec 10, 2025

this will allow us to update to golangci-lint v2.7 it complains about the package name 'api'

Summary by CodeRabbit

  • Chores
    • Updated linting configuration to adjust code quality checks.

✏️ Tip: You can customize this high-level summary in your review settings.

this will allow us to update to golangci-lint v2.7
it complains about the package name 'api'
@coderabbitai
Copy link

coderabbitai bot commented Dec 10, 2025

Walkthrough

This change updates the .golangci.yml configuration file to disable the var-naming rule in the revive linter, turning off variable-naming enforcement checks during code analysis.

Changes

Cohort / File(s) Summary
Linter configuration
\.golangci\.yml
Disables the var-naming rule in revive linter settings

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Suggested reviewers

  • cfergeau

Poem

🐰 No more var names to frown upon,
The linter's watchful eye has moved along,
Revive lets variables dance and play,
In freedom's way, they'll have their say! 🎉

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: disabling the var-naming rule for revive in the linters configuration, which aligns with the file modification shown in the raw summary.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7223a8f and 949ae41.

📒 Files selected for processing (1)
  • .golangci.yml (1 hunks)
🔇 Additional comments (1)
.golangci.yml (1)

5-9: Verify this is the intended approach to address the var-naming issue.

The change disables the var-naming rule entirely to accommodate the package name 'api'. While this unblocks the golangci-lint v2.7 upgrade, it removes enforcement of variable naming conventions across the entire codebase.

Before merging, please verify:

  1. Confirm the syntax is correct for golangci-lint v2.7 — verify the configuration is compatible with the target version.
  2. Explore more targeted alternatives — check if the revive linter's var-naming rule supports configuration options (like exception patterns or excludes) to handle the 'api' package name without disabling the entire rule.
  3. Clarify the naming conflict — ensure there's no way to rename the package or rework the import structure to avoid the conflict, as short package names like 'api' are idiomatic in Go.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@cfergeau cfergeau merged commit f8145e1 into crc-org:master Dec 11, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants