-
Notifications
You must be signed in to change notification settings - Fork 172
feat: implement process deactivation (soft delete) #445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat: implement process deactivation (soft delete) #445
Conversation
- Add `active` column to process table with migration - Recreate processes view to include new column - Add activateProcess and update deleteProcess to soft delete - Filter getProcessesList to only return active processes - Add Active column to ProcessesTable with filter - Add Deactivate/Activate context menu options - Create processes.activate route for reactivation Builds crbnos#440
|
@udayjain26 is attempting to deploy a commit to the Carbon Team on Vercel. A member of the Team first needs to authorize it. |
crudmachine
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
This looks great, but can we support the ability to both Delete and Deactivate? Sometimes a process gets created in error. It's good to be able to delete it if it hasn't been used anywhere. |
- Add deactivateProcess service function for soft delete - Restore deleteProcess to do actual hard delete - Add deactivate route for soft delete (deactivation) - Update ProcessesTable to show both Deactivate and Delete options - Add deactivateProcess path helper
|
@crudmachine @barbinbrad This is done. |
| activateProcess: (id: string) => | ||
| generatePath(`${x}/resources/processes/activate/${id}`), | ||
| deactivateProcess: (id: string) => | ||
| generatePath(`${x}/resources/processes/deactivate/${id}`) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These should be alphabetized. Maybe rename them processActivate and processDeactivate` so that we can group them together
Summary
Changes
activecolumn to process table with database migrationactivateProcessservice function and updatedeleteProcessto do soft deletegetProcessesListto only return active processes (hides from dropdowns)processes.activateroute for reactivationTest plan
Mandatory Tasks (DO NOT REMOVE)
output.mp4
Builds #440