Changes since your save link on new version game transfer #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will turn the hash description of the latest version into a clickable link to the remote repository (Github) commit description page for the commit resulting in this new version. A little convenience feature for those curious about what changed, I suppose.
There could be multiple commits since the last version your game was running on, so a description of the latest commit is only so useful. Let's compare the hash of your current game with the hash of the latest version.
|
I'd worry that linking to a raw changelist of code wouldn't be very friendly for users, especially non-programmer users. Could we list to a diff of the changelog.txt instead? |
|
Github provides a decently user-friendly list of the commits between hashes in the compare, so as long as devs are committing with decently worded commit messages I might think that would be more beneficial even to the average user. Otherwise you're imposing that each commit must update changelog.txt in some way for this feature to be remotely useful. I do see what you're saying but I think that github is user-friendly enough to maybe get some "non-programmers" to start to poke around and check things out which is probably also a good thing. |
refracta
referenced
this pull request
in refracta/dcss-server
May 20, 2024
Feature/fork collection server
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will create a link on the new version game transfer dialogue on webtiles when there is a newer crawl-git version than your currently saved game, comparing the hash of your game with the hash of the new version, using github's compare page. This is a neat little convenience feature for those curious about what exactly is changing from build to build and how it may impact their current game.
Tested with the provided docker build, inserting a bogus value into the versions table to indicate a new version had been created, resulting in the following screenshot. Currently looks like this: https://i.imgur.com/wzTf04g.png
The concept seems fine, could be room to improve in design/implementation. That is, how it's configured, where the link appears, the text of the link, etc. Could be edge cases I'm not thinking of.