Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve spacing issues in UI #252

Open
wants to merge 5 commits into
base: 3.x
Choose a base branch
from
Open

Improve spacing issues in UI #252

wants to merge 5 commits into from

Conversation

bencroker
Copy link

@bencroker bencroker commented Jun 14, 2024 •
edited
Loading

This PR addresses spacing issues that regularly results in rogue trailing lines. It is based on the work of @devolute:
https://mastodon.social/@devolute/112615852011105973

  1. Sets the CKEditor branding to outside.
  2. Equalises vertical padding.
  3. Forces 0 padding after the last child in a list.

Before:

1be25a9b6ca46937

After:

949df88befc41946

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brandonkelly brandonkelly Awaiting requested review from brandonkelly brandonkelly is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@bencroker