Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/set utm service #856

Merged
merged 3 commits into from
Jan 8, 2024
Merged

Conversation

Timple
Copy link
Contributor

@Timple Timple commented Dec 21, 2023

This is a forward port of both #627 and #830

Comparing these two commits to their respective PR's is probably the easiest to review 🙂

Copy link
Collaborator

@SteveMacenski SteveMacenski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wasn't in the original discussions for this, but this seems reasonable to forward port

src/navsat_transform.cpp Outdated Show resolved Hide resolved
@Timple
Copy link
Contributor Author

Timple commented Dec 22, 2023

Well, I'm not sure were it went wrong in the porting to ROS2, but here we are 🙂

Once upon a time, we even proposed to the UTMtoLL and LLtoUTM functions as they are pretty much empty now: #626 (comment)

Would you like a follow-up PR for this on the ros2 branch? If we don't backport it to the releases, api compatibility is kept.

@ayrton04 ayrton04 merged commit 75a26bf into cra-ros-pkg:ros2 Jan 8, 2024
2 checks passed
@ayrton04
Copy link
Collaborator

ayrton04 commented Jan 8, 2024

Thanks!

HaoguangYang added a commit to HaoguangYang/robot_localization that referenced this pull request Mar 26, 2024
* Changelogs

* 3.4.0

* Adding issue templates

* Update issue templates

* install headers (cra-ros-pkg#786)

* bump Humble to 3.4.1 for release (cra-ros-pkg#789)

* bumping to 3.4.2 for humble release (cra-ros-pkg#806)

* bumping humble to 3.5.1 to override incorrect binaries (cra-ros-pkg#816)

* Utm using geographiclib humble branch (cra-ros-pkg#834)

* Add single test for navsat_conversions

* Add a southern point to the navsat_transform test

* LLtoUTM using GeographicLib

* Use GeographicLib for UTMtoLL conversions

* Linting

* Forgot include

* Fix compilation

* Calculate gamma because it's a function output and was supplied before

* Also test for gamma conversion

* Align naming and install

* Utm using geographiclib ros2 branch (cra-ros-pkg#833)

* Add single test for navsat_conversions

* Add a southern point to the navsat_transform test

* LLtoUTM using GeographicLib

* Use GeographicLib for UTMtoLL conversions

* Linting

* Forgot include

* Fix compilation

* Calculate gamma because it's a function output and was supplied before

* Also test for gamma conversion

* Align naming and install

* Test navsat transform functionality (cra-ros-pkg#838)

* Wait for odometry message before setting manual datum so that the base and world frame names can be set. (cra-ros-pkg#835)

* wait for odom msg before setting manual datum

* Wait for odometry message before setting manual datum so that the base and world frame names can be set. (cra-ros-pkg#836)

* wait for odom msg before setting manual datum

* fix header timestamp (cra-ros-pkg#852)

Co-authored-by: Luke Chang <[email protected]>

* fix header timestamp (cra-ros-pkg#852)

Co-authored-by: Luke Chang <[email protected]>

* Changelogs

* 3.5.2

* Fixing angle clamping for humble (cra-ros-pkg#854)

* fix: modify dual_ekf_navsat_example.launch file to remap the correct imu topic (cra-ros-pkg#857)

* Feature/set utm service (cra-ros-pkg#856)

* Forward port Fix/set utm map frame change

---------

Signed-off-by: Tim Clephas <[email protected]>

* simplified calculation

* simplified calculation

* Update issue templates

* Migrate static tfs to ros2 format. (cra-ros-pkg#864)

* Fix throttle duration (cra-ros-pkg#866)

* Fix throttle duration

* Update ukf.yaml to match ekf.yaml (cra-ros-pkg#867)

Add missing *_pose_use_child_frame parameter.

* updated file formatting

---------

Signed-off-by: Tim Clephas <[email protected]>
Co-authored-by: Tom Moore <[email protected]>
Co-authored-by: Olivier Kermorgant <[email protected]>
Co-authored-by: Steve Macenski <[email protected]>
Co-authored-by: Tim Clephas <[email protected]>
Co-authored-by: Tom Greier <[email protected]>
Co-authored-by: Luke Chang <[email protected]>
Co-authored-by: Luke Chang <[email protected]>
Co-authored-by: joeldushouyu <[email protected]>
Co-authored-by: Mukunda Bharatheesha <[email protected]>
Co-authored-by: thandal <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants