Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed geographiclib to <depend> tag #684

Merged
merged 1 commit into from
Jul 20, 2021
Merged

changed geographiclib to <depend> tag #684

merged 1 commit into from
Jul 20, 2021

Conversation

VAM7686
Copy link

@VAM7686 VAM7686 commented Jul 17, 2021

Currently, robot_localization only pulls in the GeographicLib package as a build dependency and only installs libgeographic19 which gives us the shared library files, but not the headers.

Since #626 added headers from GeographicLib the tags for GeographicLib in package.xml need to be changed from <build_depend> to <depend>

@ayrton04
Copy link
Collaborator

So changing it to a depend installs the headers? We don't need to change the dependency to geographiclib-dev or anything?

@ayrton04
Copy link
Collaborator

Merging, since this won't hurt anything regardless of the answer to my question.

@ayrton04 ayrton04 merged commit 0f66aa0 into cra-ros-pkg:noetic-devel Jul 20, 2021
@VAM7686
Copy link
Author

VAM7686 commented Jul 20, 2021

So changing it to a depend installs the headers? We don't need to change the dependency to geographiclib-dev or anything?

The <build_depend> tag only installs the dependency to build the package and not for execution time. Changing it to <depend> tags is the same as specifying <build_depend>, <build_export_depend>, and <exec_depend> for the dependency. Doing so installs the dependency to be used at build time and execution time. More information about the dependency tags can be found at REP 149.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants