Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix npm audit and codecov CI #328

Merged
merged 4 commits into from
Nov 12, 2024
Merged

Fix npm audit and codecov CI #328

merged 4 commits into from
Nov 12, 2024

Conversation

cmoesel
Copy link
Member

@cmoesel cmoesel commented Oct 23, 2024

This PR contains three maintenance fixes:

  1. It resolves all reported vulnerabilities in dependencies (via npm audit fix).
  2. It updates the GitHub Action to use a CodeCov GitHub action instead of the codecov script (as that script is now deprecated and failing).
  3. It updates existing actions in the GitHub CI to use their latest versions.

To test:

  1. Run npm audit and confirm there are no reported vulnerabilities.
  2. Review GitHub actions invoked by this PR and confirm that all actions pass and CodeCov is working correctly.

Submitter:

  • This pull request describes why these changes were made
  • Code diff has been done and been reviewed (it does not contain: additional white space, not applicable code changes, debug statements, etc.)
  • Tests are included and test edge cases - N/A
  • Tests have been run locally and pass
  • Code coverage has not gone down and all code touched or added is covered. - N/A
  • Code passes lint and prettier (hint: use npm run test:plus to run tests, lint, and prettier)
  • All dependent libraries are appropriately updated or have a corresponding PR related to this change
  • cql4browsers.js built with npm run build:browserify if source changed.

Reviewer:

Name:

  • Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose
  • The tests appropriately test the new code, including edge cases
  • You have tried to break the code

The npx codecov script is deprecated, so use the GitHub action instead.
@codecov-commenter
Copy link

codecov-commenter commented Oct 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.04%. Comparing base (27c9bf7) to head (3de86a4).
Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #328      +/-   ##
==========================================
+ Coverage   86.15%   87.04%   +0.89%     
==========================================
  Files          52       52              
  Lines        4508     4517       +9     
  Branches     1270     1273       +3     
==========================================
+ Hits         3884     3932      +48     
- Misses        324      377      +53     
+ Partials      300      208      -92     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@elsaperelli elsaperelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Also tested with fqm-execution regression script!

@cmoesel cmoesel merged commit 12a8ce0 into master Nov 12, 2024
8 checks passed
@cmoesel cmoesel deleted the npm-audit-and-codecov branch November 12, 2024 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants