-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make sure the bot has the right email and password in config #54
base: master
Are you sure you want to change the base?
Conversation
in work can't test it right now, should work?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This brings up some interesting security problems with having the email and password globally accessible from a module.
The plugins shouldn't be able to access this information.
I like it.
steely/plugins/login.py
Outdated
COMMAND = ".login" | ||
|
||
def main(bot, author_id, thread_id, thread_type, **kwargs): | ||
bot.sendMessage(config.EMAIL, config.PASSWORD, thread_id=thread_id, thread_type=thread_type) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does sendMessage
work with varargs? You might need to concatenate the email and password into a single string first.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure, I'll look at it when I'm home, you're probably right
well i think if even they were in a yaml file or something, the plugins could access them |
You're right. @CianLR and I were talking about ways to avoid this yesterday. It seems hard. |
@byxor It actually isn't that hard. Just use a strikethrough to encrypt the password like this:
|
|
@sentriz yes test it again with your credit card details to confirm whether it will work for microtransactions |
Hi @sentriz great to see this PR is re-opened. Looking forward to a merge for 2022! 🥇 💠 🚀 🕋 💎 |
This PR does not meet this project's updated coding guidelines or standard of contribution. Please read our CONTRIBUTING.md file for more information on making a contribution. In particular:
Yours cordially, Noah 🚀 Steely wouldn't be possible without the continued support of our great community! Please feel free to make a donation to the team's bitcoin address: 💌 How did we do? Help us improve! We welcome your feedback and comments; just send an email to CONFIDENTIALITY NOTICE: The contents of this email message and any attachments are intended solely for the addressee(s) and may contain confidential and/or privileged information and may be legally protected from disclosure. ........ Preserve nature! Please reconsider not printing out this message. |
in work can't test it right now, should work?