Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make sure the bot has the right email and password in config #54

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

izaakf
Copy link
Member

@izaakf izaakf commented Aug 28, 2017

in work can't test it right now, should work?

in work can't test it right now, should work?
Copy link
Collaborator

@byxor byxor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This brings up some interesting security problems with having the email and password globally accessible from a module.

The plugins shouldn't be able to access this information.

I like it.

COMMAND = ".login"

def main(bot, author_id, thread_id, thread_type, **kwargs):
bot.sendMessage(config.EMAIL, config.PASSWORD, thread_id=thread_id, thread_type=thread_type)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does sendMessage work with varargs? You might need to concatenate the email and password into a single string first.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure, I'll look at it when I'm home, you're probably right

@sentriz
Copy link
Member

sentriz commented Aug 28, 2017

well i think if even they were in a yaml file or something, the plugins could access them

@byxor
Copy link
Collaborator

byxor commented Aug 29, 2017

You're right. @CianLR and I were talking about ways to avoid this yesterday. It seems hard.

@izaakf
Copy link
Member Author

izaakf commented Aug 29, 2017

@byxor It actually isn't that hard. Just use a strikethrough to encrypt the password like this:

password

@sentriz
Copy link
Member

sentriz commented Aug 29, 2017

hunter2 did it work?

@izaakf
Copy link
Member Author

izaakf commented Aug 29, 2017

@sentriz yes test it again with your credit card details to confirm whether it will work for microtransactions

@izaakf izaakf closed this Sep 5, 2017
@sentriz sentriz reopened this Jan 26, 2021
@izaakf
Copy link
Member Author

izaakf commented Jan 26, 2021

Hi @sentriz great to see this PR is re-opened. Looking forward to a merge for 2022! 🥇 💠 🚀 🕋 💎

@iandioch
Copy link
Collaborator

This PR does not meet this project's updated coding guidelines or standard of contribution. Please read our CONTRIBUTING.md file for more information on making a contribution.

In particular:

  • Add tests for your feature, idiot

Yours cordially,

Noah
Steely community manager


🚀 Steely wouldn't be possible without the continued support of our great community! Please feel free to make a donation to the team's bitcoin address: 1En4K9siexgeBfWtHb2LvaumC33yymUug8


💌 How did we do? Help us improve! We welcome your feedback and comments; just send an email to [email protected]!


CONFIDENTIALITY NOTICE: The contents of this email message and any attachments are intended solely for the addressee(s) and may contain confidential and/or privileged information and may be legally protected from disclosure.

........

Preserve nature! Please reconsider not printing out this message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants