N/message interface #216
Merged
N/message interface #216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…th SteelyMessages
CianLR
approved these changes
Oct 21, 2020
|
Thanks for the quick review. Not sure if I mentioned it earlier, but this PR is necessary for steely to work on the newer version of the telegrab lib... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Working towards #203.
The only visible change after this PR is that new plugins introduced in #215 take just (bot, message, **kwargs). But it means we can add new things (like image_url, sticker data, etc) that was included in messages, without changing the signature of any plugins... The new data can just be included in
SteelyMessage.I'm on the fence at also changing explicit /command calls to get some
CommandCallobj containing the args and rest of message, instead of the args being added tokwargsand themessage.textbeing (perhaps surprisingly?) a substring of the actually sent message. LMK if you have thoughts.