Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Berry Picking Editorial #5040

Merged
merged 8 commits into from
Jan 17, 2025
Merged

Berry Picking Editorial #5040

merged 8 commits into from
Jan 17, 2025
+26 −14

Conversation

JoltedCowIceCream
Copy link
Contributor

  • added explanation to internal solution pages

Place an "x" in the corresponding checkbox if it is done or does not apply to this pull request.

  • I have tested my code.
  • I have added my solution according to the steps here.
  • I have followed the code conventions mentioned here.
    • I understand that if it is clear that I have not attempted to follow these conventions, my PR will be closed.
    • If changes are requested, I will re-request a review after addressing them.
  • I have linked this PR to any issues that it closes.

TheGamingMousse
TheGamingMousse reviewed Jan 14, 2025
View reviewed changes
Copy link
Contributor

@TheGamingMousse TheGamingMousse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

explanation looks fine to me

in the mean time, could you remove the like 998244353 macroes in the C++ solution?

@SansPapyrus683 SansPapyrus683 merged commit 00a8002 into cpinitiative:master Jan 17, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheGamingMousse TheGamingMousse TheGamingMousse approved these changes

@SansPapyrus683 SansPapyrus683 SansPapyrus683 approved these changes

@ryanchou-dev ryanchou-dev Awaiting requested review from ryanchou-dev ryanchou-dev is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JoltedCowIceCream @SansPapyrus683 @TheGamingMousse