fix(cozy-dataproxy-lib): Embed assistant's icon as base64 instead of PNG #2732
+30
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The assistant's icon cannot be a SVG because it uses some conical gradients Also we don't want to embed it as a PNG resource for now because we encounter some issues in the Flagship app's WebViews when loaded in offline mode (the cache control seems not to work after an app's restart) To fix those issues, we chose to embed the icon PNG as a base64 string until we find a better solution.
Ldoppea
requested review from
JF-Cozy,
Merkur39,
zatteo and
doubleface
as code owners
zatteo
approved these changes
Feb 10, 2025
Ldoppea
added a commit
to cozy/cozy-home
that referenced
this pull request
Feb 11, 2025
`cozy-dataproxy-lib` has been upgraded to `3.4.1` in order to retrieve a fix on the Assistant icon that would not be displayed on Flagship app in offline mode Related PR: cozy/cozy-libs#2732
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The assistant's icon cannot be a SVG because it uses some conical gradients
Also we don't want to embed it as a PNG resource for now because we encounter some issues in the Flagship app's WebViews when loaded in offline mode (the cache control seems not to work after an app's restart)
To fix those issues, we chose to embed the icon PNG as a base64 string until we find a better solution.