Revert #64 #66
Merged
Revert #64 #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM, do we need to rerun something to fix the data from the past 2 hours? |
bram-vdberg
approved these changes
Oct 4, 2024
The code should work hopefully work fine after the revert. The failed writes to the database should in principle look just like the price feed we used before. Since there was no data for a long time until this morning, there is also no need to clean up data for correctness. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change from #64 to add additional price feeds broke an assumtion of the slippage prices table.
The
slippage_pricestable has(tx_hash, token_address)as primary key. This is incompatible with having multiple prices per token and transaction.The talbe layout should be changed.