Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hex bug fix #42

Merged
merged 4 commits into from
Aug 23, 2024
Merged

Hex bug fix #42

merged 4 commits into from
Aug 23, 2024

Conversation

harisang
Copy link
Contributor

This PR fixes some minor bug introduced in PR #31 with the conversion of Hex Bytes to strings and vice versa.

Copy link
Contributor

@bram-vdberg bram-vdberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to apply this change to the whole project? I see we use the .hex() method in a few other files as well.

@shubhagarwal03
Copy link
Contributor

I'll check to see if its needed in other files, but I believe the rest of the codebase is as is, and had no issues in the prev deployment.

@fhenneke
Copy link
Contributor

There is one conversion to to_0x_hex missing in the get_order_data function.

Some of the other uses are for use in other methods of the package. Some of the should handle strings without 0x prefix correctly. But probably worth double checking.

@harisang
Copy link
Contributor Author

harisang commented Aug 23, 2024

Yeah good catch, just pushed the fix for the get_order_data() function. Getting rate limited again so will wait to test it locally before merging.

@harisang harisang merged commit b5da1e1 into main Aug 23, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants