Ignore failing test #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You could just put an ignore/skip tag on the test with a todo and corresponding issue to get back to it. |
|
If this test is consistently failing, this seems to suggest that the only source of truth now is the Dune table. If it were wiped, we might not be able to recreate that record... This Dune query, shows the record we expect to find on IPFS: https://dune.com/queries/3381890 The failing tests seems to imply that this record is no longer available on IPFS. |
fhenneke
approved these changes
Jan 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes a failing IPFS test, as reported in issue #60 . Although it would be nice to fix, we don't really have the capacity for this now, and so i am proposing to remove this test so that we don't get constant failures in all the PRs that we are doing at the moment.
UPDATE: We followed @bh2smith 's suggestion and just ignored the test for now instead of removing it.