Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(widget): flexible config for partner fee params (#392) #396

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

anxolin
Copy link
Contributor

@anxolin anxolin commented Jun 20, 2024

Description

Adds some additional information on the options for partner fee, so we are more explicit saying that the simplest config will affect all flows and networks.

image

Test

Review https://docs-git-clarify-partner-fee-options-cowswap.vercel.app/cow-protocol/tutorials/widget#partner-fee

Copy link

vercel bot commented Jun 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview Jun 24, 2024 4:39pm

@anxolin anxolin force-pushed the clarify-partner-fee-options branch from 42c31dd to 6c3bdea Compare June 20, 2024 08:53
@anxolin anxolin marked this pull request as ready for review June 20, 2024 08:54
@anxolin anxolin requested a review from a team as a code owner June 20, 2024 08:54
@anxolin anxolin requested review from cmagan and shoom3301 June 20, 2024 08:54
@@ -69,6 +69,8 @@ const params: CowSwapWidgetParams = {
createCowSwapWidget(widgetContainer, { params })
```

This configuration will apply a partner fee for all networks and trade types (swaps, limit orders, TWAPs, etc.). You can use [Flexible config](#flexible-config) for having more flexibility, or [Advanced configuration](#advanced-configuration) to have even more control on you partner fee.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor suggestion:
"to have even more control over the partner fee configuration parameters."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants