Handle asymmetric event emission + better concurrency handling #2092

snario · 2019-08-01T17:53:47Z

Concurrency fixes:

Install virtual app now has queuing. It did not before.
Uninstall virtual app now queues on both channels with counterparties, not just one.
Update and take action now queues on app instance identity hash, not multisig address

packages/node/src/message-handling/handle-protocol-message.ts

cf19drofxots · 2019-08-01T19:53:03Z

Can you describe in the PR's description how this achieves better concurrency?

snario · 2019-08-01T21:10:30Z

Can you describe in the PR's description how this achieves better concurrency?

see above

packages/node/src/message-handling/handle-protocol-message.ts

packages/node/src/methods/app-instance/uninstall-virtual/controller.ts

packages/node/src/methods/controller.ts

packages/node/test/integration/uninstall-with-postgres.spec.ts

cf19drofxots

A couple of comments before this is good to merge

cf19drofxots · 2019-08-02T23:40:14Z

Bump package versions to pick up the new changes.

snario requested a review from cf19drofxots August 1, 2019 17:53

snario requested a review from joelalejandro as a code owner August 1, 2019 17:53

snario changed the title ~~Handle asymmetric event emission + better concurrency handlind~~ Handle asymmetric event emission + better concurrency handling Aug 1, 2019

cf19drofxots reviewed Aug 1, 2019

View reviewed changes

packages/node/src/message-handling/handle-protocol-message.ts Show resolved Hide resolved

cf19drofxots suggested changes Aug 1, 2019

View reviewed changes

snario force-pushed the liam/symmetric branch from e0c8eae to 79cae0f Compare August 2, 2019 13:38

snario requested a review from cf19drofxots August 2, 2019 16:42

cf19drofxots reviewed Aug 2, 2019

View reviewed changes

packages/node/test/integration/uninstall-with-postgres.spec.ts Show resolved Hide resolved

cf19drofxots reviewed Aug 2, 2019

View reviewed changes

snario requested a review from cf19drofxots August 2, 2019 23:36

cf19drofxots approved these changes Aug 2, 2019

View reviewed changes

snario added 9 commits August 5, 2019 10:03

Abstract out the queued function code from NodeController

54fe36a

Make handle-protocol-message correctly queue + code cleanup

26a2ce1

Better name than ret

493cc4f

Swap const method to function

d371006

Better async code

a7c86c5

Remove call to the store inside protocol message handler

8ac470a

Add a comment

21f987f

Switch to function syntax vs const lambda

0ec4140

Bump @counterfactual/node version

c78789a

snario force-pushed the liam/symmetric branch from 38ecdfe to c78789a Compare August 5, 2019 14:05

snario merged commit a096889 into master Aug 5, 2019

snario deleted the liam/symmetric branch August 5, 2019 14:16

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Handle asymmetric event emission + better concurrency handling #2092

Handle asymmetric event emission + better concurrency handling #2092

snario commented Aug 1, 2019 •

edited

Loading

cf19drofxots commented Aug 1, 2019

snario commented Aug 1, 2019

cf19drofxots left a comment

cf19drofxots commented Aug 2, 2019

Handle asymmetric event emission + better concurrency handling #2092

Handle asymmetric event emission + better concurrency handling #2092

Conversation

snario commented Aug 1, 2019 • edited Loading

cf19drofxots commented Aug 1, 2019

snario commented Aug 1, 2019

cf19drofxots left a comment

Choose a reason for hiding this comment

cf19drofxots commented Aug 2, 2019

snario commented Aug 1, 2019 •

edited

Loading