Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Bumping wasmCloud Provider SDK & WRPC #20

Merged

Conversation

lxfontes
Copy link
Contributor

@lxfontes lxfontes commented Sep 4, 2024

@brooksmtownsend
Copy link
Collaborator

Hey @lxfontes ! Looks like this just needs a rebase and it's good to go 😄

@lxfontes lxfontes force-pushed the lxfontes/bump-provider-wrpc branch from 2f7b1c9 to b58fca4 Compare October 25, 2024 17:11
@lxfontes
Copy link
Contributor Author

Hold on merging this cause with the latest wit-bindgen-wrpc we get an error

# github.com/couchbase-examples/wasmcloud-provider-couchbase/bindings/wasmcloud/couchbase/types
bindings/wasmcloud/couchbase/types/bindings.wrpc.go:1210:12: cannot use nil as wrpc.Own[DocumentValue] value in return statement
bindings/wasmcloud/couchbase/types/bindings.wrpc.go:1214:13: cannot use nil as wrpc.Own[DocumentValue] value in return statement
bindings/wasmcloud/couchbase/types/bindings.wrpc.go:1221:13: cannot use nil as wrpc.Own[DocumentValue] value in return statement
bindings/wasmcloud/couchbase/types/bindings.wrpc.go:1228:10: cannot use nil as wrpc.Own[DocumentValue] value in return statement
bindings/wasmcloud/couchbase/types/bindings.wrpc.go:1396:14: cannot use nil as wrpc.Own[DocumentValue] value in return statement

looking into it now.

@lxfontes
Copy link
Contributor Author

@brooksmtownsend good to go. ended up re-bumping wrpc & provider-sdk to their latest versions ( parity with latest wit-bindgen-wrpc ).

@brooksmtownsend brooksmtownsend merged commit 0467cdc into couchbaselabs:main Oct 28, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants