feat(wit): add definitions for a more general couchbase #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vados-cosmonic
force-pushed
the
feat(wit)=add-couchbase-general-wit
branch
3 times, most recently
from
7377e86 to
964b68c
Compare
JesusTheHun
suggested changes
Jun 11, 2024
|
@vados-cosmonic Thank you for this submission ! |
|
Hey @JesusTheHun Thanks for the detailed feedback -- I'll get to churning on these and make some updates! |
JesusTheHun
reviewed
Jun 13, 2024
vados-cosmonic
force-pushed
the
feat(wit)=add-couchbase-general-wit
branch
from
8080928 to
4e44baf
Compare
This commit adds a more general WIT interface to a Couchbase cluster, including both basic and more advanced operations that users can perform. Signed-off-by: Victor Adossi <vadossi@cosmonic.com>
vados-cosmonic
force-pushed
the
feat(wit)=add-couchbase-general-wit
branch
from
4e44baf to
d937085
Compare
Signed-off-by: Victor Adossi <vadossi@cosmonic.com>
|
Hey @JesusTheHun would love to get your feedback on fc42fa2 I've kept it separate for now to make it easier to review (hopefully) |
1 similar comment
|
Hey @JesusTheHun would love to get your feedback on fc42fa2 I've kept it separate for now to make it easier to review (hopefully) |
brooksmtownsend
approved these changes
Jun 25, 2024
JesusTheHun
reviewed
Jun 27, 2024
Signed-off-by: Victor Adossi <vadossi@cosmonic.com>
Signed-off-by: Victor Adossi <vadossi@cosmonic.com>
Signed-off-by: Victor Adossi <vadossi@cosmonic.com>
JesusTheHun
reviewed
Jun 28, 2024
Signed-off-by: Victor Adossi <vadossi@cosmonic.com>
Signed-off-by: Victor Adossi <vadossi@cosmonic.com>
Signed-off-by: Victor Adossi <vadossi@cosmonic.com>
vados-cosmonic
force-pushed
the
feat(wit)=add-couchbase-general-wit
branch
2 times, most recently
from
9b3e170 to
431bf6a
Compare
Rust has some required arguments that we don't really need to check Signed-off-by: Victor Adossi <vadossi@cosmonic.com>
vados-cosmonic
force-pushed
the
feat(wit)=add-couchbase-general-wit
branch
from
431bf6a to
82c9636
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey all thanks for this awesome project -- excited to see Couchbase integrated with wasmCloud!
This commit adds a more general WIT interface to a Couchbase cluster, including both basic and more advanced operations that users can perform.
I'm adding this PR to serve as a place to discuss the proposed API, receive feedback, etc, excited to hear what the team at couchbase thinks about this WIT as a part of their provider!