Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding impressive support to compare hidden builds #58

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Adding impressive support to compare hidden builds #58

wants to merge 1 commit into from

Conversation

devanshsa5
Copy link
Contributor

This will allow us to fetch and compare all build hidden = True or False in impresssive.

@devanshsa5 devanshsa5 requested review from bochun and d-nagy January 9, 2024 15:33
d-nagy
d-nagy approved these changes Jan 9, 2024
View reviewed changes
Copy link
Contributor

@d-nagy d-nagy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah awesome! Looks good to me 👍🏼 I think we should definitely not be constrained to only compare builds which are visible on showfast

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d-nagy d-nagy d-nagy approved these changes

@bochun bochun Awaiting requested review from bochun

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@devanshsa5 @d-nagy