Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tj202/pr add qol #39

Merged
merged 14 commits into from
Jan 23, 2025
Merged

Tj202/pr add qol #39

merged 14 commits into from
Jan 23, 2025

Conversation

TJ202
Copy link
Collaborator

@TJ202 TJ202 commented Jan 10, 2025

  • More documentation for the “agentc add” command, illustrating the user workflow
    • Remove the “this file was autogenerated on …” line for all files generated by “agentc add”. This was confusing to some users, suggesting that these files could not be edited.
    • Add a line to the docstring of “agentc add” that informs the user that they must edit the generated file afterward.
    • In the docs for the user guide, add the above disclaimer as well. (this is taken care of by cli docstring)
    • Open file using vi after

@TJ202 TJ202 added the wip This pr is work in progress label Jan 10, 2025
@TJ202 TJ202 requested a review from glennga January 20, 2025 06:25
@TJ202 TJ202 removed the wip This pr is work in progress label Jan 20, 2025
@TJ202 TJ202 requested a review from ThejasNU January 20, 2025 06:26
libs/agentc_cli/agentc_cli/cmds/add.py Outdated Show resolved Hide resolved
libs/agentc_cli/agentc_cli/cmds/add.py Outdated Show resolved Hide resolved
@TJ202 TJ202 requested a review from glennga January 23, 2025 06:08
Copy link
Collaborator

@ThejasNU ThejasNU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

Copy link
Collaborator

@glennga glennga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TJ202 TJ202 merged commit f535ce3 into master Jan 23, 2025
5 checks passed
@TJ202 TJ202 deleted the tj202/PR_add_qol branch January 23, 2025 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants