No Op On Redundant Update #501
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdityaSripal
commented
Apr 15, 2025
Comment on lines
+233
to
+235
| let header_bz: Vec<u8> = serde_json::to_vec(&header).unwrap(); | ||
| let header_bz2: Vec<u8> = header_bz.clone(); | ||
| let header_bz3: Vec<u8> = header_bz.clone(); |
Contributor
Author
There was a problem hiding this comment.
did this just to shut the compiler up but lmk what the canonical solution is @srdtrk
Comment on lines
+265
to
+280
| verify_client_message( | ||
| deps.as_ref(), | ||
| env2, | ||
| VerifyClientMessageMsg { | ||
| client_message: Binary::from(header_bz3), | ||
| }, | ||
| ) | ||
| .unwrap(); | ||
|
|
||
| update_state( | ||
| deps.as_mut(), | ||
| UpdateStateMsg { | ||
| client_message: Binary::from(header_bz4), | ||
| }, | ||
| ) | ||
| .unwrap(); |
Contributor
Author
There was a problem hiding this comment.
Both calls fail here with their respective no-op code commented out
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #501 +/- ##
=======================================
Coverage 99.86% 99.86%
=======================================
Files 15 15
Lines 766 766
=======================================
Hits 765 765
Misses 1 1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR intercepts the message before it reaches the ethereum client package and no-ops on
VerifyClientMessageandUpdateStateMsgif the header slot is the same as the latest consensus state height.It is intended as the most feasible stopgap solution before allowing historical updates
Note it does not check if the header is valid at all. We can't do header verification here without historical updates since the cosmwasm contract grabs the latest consensus state as the trusted state automatically. We cannot no-op in this case in the verification package as that would simply be a bug in the library.
It also does not implement automatic misbehaviour detection since this would require historical updates.
I have this PR up along with tests to show that this can work. But given the above reasons, I think it is most wise to simply go directly to allowing historical updates which is what i will work on next.
Leaving this PR up so that the team has context on my decision.
closes: #XXXX
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
godoccomments.Files changedin the GitHub PR explorer.SonarCloud Reportin the comment section below once CI passes.