Democracry consumer app refactors #679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shaspitz
requested review from
jtremback,
mpoke,
sainoe,
MSalopek,
mmulji-ic,
glnro and
yaruwangway
as code owners
yaruwangway
approved these changes
Feb 2, 2023
MSalopek
requested changes
Feb 7, 2023
MSalopek
approved these changes
Feb 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactors to make the democ consumer app more understandable. Makes package aliases more accurate. Some alias' were prefixed with
ccv, suggesting they came from this repo, when those packages were actually from the sdk repo.This change will make PRs such as Stride-Labs#1 easier to review, where the intricacies of package dependancies are important.
I believe this shouldn't affect production code at all, correct me if wrong
Type of change
Refactor: Changes existing code style, naming, structure, etc.Regression tests
All existing tests do not fail. These changes should be harmless