feat: implement slashing functionality on the provider chain (ADR-013)

tests/integration/double_vote.go

@@ -10,7 +10,7 @@ import (
 )
 
 // TestHandleConsumerDoubleVoting verifies that handling a double voting evidence
-// of a consumer chain results in the expected jailing of the malicious validator
+// of a consumer chain results in the expected tombstoning, jailing, and slashing of the malicious validator
 func (s *CCVTestSuite) TestHandleConsumerDoubleVoting() {
 	s.SetupCCVChannel(s.path)
 	// required to have the consumer client revision height greater than 0
@@ -159,6 +159,9 @@ func (s *CCVTestSuite) TestHandleConsumerDoubleVoting() {
 	consuAddr := types.NewConsumerConsAddress(sdk.ConsAddress(consuVal.Address.Bytes()))
 	provAddr := s.providerApp.GetProviderKeeper().GetProviderAddrFromConsumerAddr(s.providerCtx(), s.consumerChain.ChainID, consuAddr)
 
+	validator, _ := s.providerApp.GetTestStakingKeeper().GetValidator(s.providerCtx(), provAddr.ToSdkConsAddr().Bytes())
+	initialTokens := validator.GetTokens().ToDec()
+
 	for _, tc := range testCases {
 		s.Run(tc.name, func() {
 			// reset context for each run
@@ -185,8 +188,15 @@ func (s *CCVTestSuite) TestHandleConsumerDoubleVoting() {
 			if tc.expPass {
 				s.Require().NoError(err)
 
-				// verifies that the jailing has occurred
+				// verifies that the tombstoning and jailing has occurred
+				s.Require().True(s.providerApp.GetTestSlashingKeeper().IsTombstoned(provCtx, provAddr.ToSdkConsAddr()))
 				s.Require().True(s.providerApp.GetTestStakingKeeper().IsValidatorJailed(provCtx, provAddr.ToSdkConsAddr()))
+
+				// verifies that the validator gets slashed and has fewer tokens after the slashing
+				validator, _ := s.providerApp.GetTestStakingKeeper().GetValidator(provCtx, provAddr.ToSdkConsAddr().Bytes())
+				slashFraction := s.providerApp.GetTestSlashingKeeper().SlashFractionDoubleSign(provCtx)
+				actualTokens := validator.GetTokens().ToDec()
+				s.Require().True(initialTokens.Sub(initialTokens.Mul(slashFraction)).Equal(actualTokens))
 			} else {
 				s.Require().Error(err)
 

tests/integration/misbehaviour.go

@@ -53,16 +53,26 @@ func (s *CCVTestSuite) TestHandleConsumerMisbehaviour() {
 		),
 	}
 
+	// we assume that all validators have the same number of initial tokens
+	validator, _ := s.getValByIdx(0)
+	initialTokens := validator.GetTokens().ToDec()
+
 	err := s.providerApp.GetProviderKeeper().HandleConsumerMisbehaviour(s.providerCtx(), *misb)
 	s.NoError(err)
 
-	// verify that validators are jailed and tombstoned
+	// verify that validators are jailed, tombstoned, and slashed
 	for _, v := range clientTMValset.Validators {
 		consuAddr := sdk.ConsAddress(v.Address.Bytes())
 		provAddr := s.providerApp.GetProviderKeeper().GetProviderAddrFromConsumerAddr(s.providerCtx(), s.consumerChain.ChainID, types.NewConsumerConsAddress(consuAddr))
 		val, ok := s.providerApp.GetTestStakingKeeper().GetValidatorByConsAddr(s.providerCtx(), provAddr.Address)
 		s.Require().True(ok)
 		s.Require().True(val.Jailed)
+		s.Require().True(s.providerApp.GetTestSlashingKeeper().IsTombstoned(s.providerCtx(), provAddr.ToSdkConsAddr()))
+
+		validator, _ := s.providerApp.GetTestStakingKeeper().GetValidator(s.providerCtx(), provAddr.ToSdkConsAddr().Bytes())
+		slashFraction := s.providerApp.GetTestSlashingKeeper().SlashFractionDoubleSign(s.providerCtx())
+		actualTokens := validator.GetTokens().ToDec()
+		s.Require().True(initialTokens.Sub(initialTokens.Mul(slashFraction)).Equal(actualTokens))
 	}
 }
 

x/ccv/provider/keeper/double_vote.go

@@ -3,8 +3,9 @@ package keeper
 import (
 	"bytes"
 	"fmt"
-
 	cryptotypes "github.com/cosmos/cosmos-sdk/crypto/types"
+	"github.com/cosmos/cosmos-sdk/x/evidence/exported"
+	evidencetypes "github.com/cosmos/cosmos-sdk/x/evidence/types"
 
 	sdk "github.com/cosmos/cosmos-sdk/types"
 	sdkerrors "github.com/cosmos/cosmos-sdk/types/errors"
@@ -33,8 +34,18 @@ func (k Keeper) HandleConsumerDoubleVoting(
 		types.NewConsumerConsAddress(sdk.ConsAddress(evidence.VoteA.ValidatorAddress.Bytes())),
 	)
 
-	// execute the jailing
-	k.JailValidator(ctx, providerAddr)
+	k.SlashValidator(ctx, providerAddr)
+	k.JailAndTombstoneValidator(ctx, providerAddr)
+
+	// FIXME: verify the following values
+	var equivocation exported.Evidence = &evidencetypes.Equivocation{
+		Height:           evidence.Height(),
+		Time:             evidence.Time(),
+		Power:            evidence.ValidatorPower,
+		ConsensusAddress: evidence.VoteA.ValidatorAddress.String(),
+	}
+
+	k.evidenceKeeper.SetEvidence(ctx, equivocation)
 
 	k.Logger(ctx).Info(
 		"confirmed equivocation",

x/ccv/provider/keeper/misbehaviour.go

@@ -1,12 +1,13 @@
 package keeper
 
 import (
-	"github.com/cosmos/interchain-security/v2/x/ccv/provider/types"
-
 	sdk "github.com/cosmos/cosmos-sdk/types"
 	sdkerrors "github.com/cosmos/cosmos-sdk/types/errors"
+	"github.com/cosmos/cosmos-sdk/x/evidence/exported"
+	evidencetypes "github.com/cosmos/cosmos-sdk/x/evidence/types"
 	ibcclienttypes "github.com/cosmos/ibc-go/v4/modules/core/02-client/types"
 	ibctmtypes "github.com/cosmos/ibc-go/v4/modules/light-clients/07-tendermint/types"
+	"github.com/cosmos/interchain-security/v2/x/ccv/provider/types"
 	tmtypes "github.com/tendermint/tendermint/types"
 )
 
@@ -41,10 +42,22 @@ func (k Keeper) HandleConsumerMisbehaviour(ctx sdk.Context, misbehaviour ibctmty
 			misbehaviour.Header1.Header.ChainID,
 			types.NewConsumerConsAddress(sdk.ConsAddress(v.Address.Bytes())),
 		)
-		k.JailValidator(ctx, providerAddr)
+		k.SlashValidator(ctx, providerAddr)
+		k.JailAndTombstoneValidator(ctx, providerAddr)
 		provAddrs = append(provAddrs, providerAddr)
 	}
 
+	// FIXME: it would be nice to set the evidence but not sure what this would mean
+	// for light client attacks.
+	var evidence exported.Evidence = &evidencetypes.Equivocation{
+		Height:           int64(misbehaviour.Header1.GetHeight().GetRevisionHeight()),
+		Time:             misbehaviour.Header2.GetTime(),
+		Power:            0,
+		ConsensusAddress: "!",
+	}
+
+	k.evidenceKeeper.SetEvidence(ctx, evidence)
+
 	logger.Info(
 		"confirmed equivocation light client attack",
 		"byzantine validators", provAddrs,