-
Notifications
You must be signed in to change notification settings - Fork 716
RateLimit V2 E2E #8568
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: gjermund/ibc-v2-relaying
Are you sure you want to change the base?
RateLimit V2 E2E #8568
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## gjermund/ibc-v2-relaying #8568 +/- ##
============================================================
- Coverage 57.61% 1.13% -56.49%
============================================================
Files 317 14 -303
Lines 22675 2027 -20648
============================================================
- Hits 13065 23 -13042
+ Misses 9005 2003 -7002
+ Partials 605 1 -604
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's quite a bit that one could pull out into helper fns. Namely the broadcast tx and v2 transfer. Though this would be good to do at a testing library level so all e2e tests can use it.
As it stands now, i think this is quite readable
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks nice. 🎊
s.Require().NoError(err) | ||
|
||
// Spin up relayer API | ||
relayerConfig := config.NewConfig(config.CreateCosmosCosmosModules(config.CosmosToCosmosConfigInfo{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know this is from the library, still, CosmosCosmos reads weird. Especially when the parameter it takes is called CosmosToCosmosConfidInfo
Description
closes: #XXXX
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/
) if anything is changed.godoc
comments if relevant.Files changed
in the GitHub PR explorer.