Skip to content

Conversation

AdityaSripal
Copy link
Contributor

Description

closes: #XXXX


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Linked to GitHub issue with discussion and accepted design, OR link to spec that describes this work.
  • Include changelog entry when appropriate (e.g. chores should be omitted from changelog).
  • Wrote unit and integration tests if relevant.
  • Updated documentation (docs/) if anything is changed.
  • Added godoc comments if relevant.
  • Self-reviewed Files changed in the GitHub PR explorer.
  • Provide a conventional commit message to follow the repository standards.

@AdityaSripal AdityaSripal changed the base branch from main to gjermund/ibc-v2-relaying June 27, 2025 10:52
Copy link

codecov bot commented Jun 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 1.13%. Comparing base (e771540) to head (cdd8994).

❗ There is a different number of reports uploaded between BASE (e771540) and HEAD (cdd8994). Click for more details.

HEAD has 2 uploads less than BASE
Flag BASE (e771540) HEAD (cdd8994)
08-wasm 1 0
ibc-go 1 0
Additional details and impacted files
@@                     Coverage Diff                      @@
##           gjermund/ibc-v2-relaying   #8568       +/-   ##
============================================================
- Coverage                     57.61%   1.13%   -56.49%     
============================================================
  Files                           317      14      -303     
  Lines                         22675    2027    -20648     
============================================================
- Hits                          13065      23    -13042     
+ Misses                         9005    2003     -7002     
+ Partials                        605       1      -604     
Flag Coverage Δ
08-wasm ?
e2e 1.13% <ø> (ø)
ibc-go ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor Author

@AdityaSripal AdityaSripal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's quite a bit that one could pull out into helper fns. Namely the broadcast tx and v2 transfer. Though this would be good to do at a testing library level so all e2e tests can use it.

As it stands now, i think this is quite readable

Copy link
Contributor

@DeshErBojhaa DeshErBojhaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice. 🎊

s.Require().NoError(err)

// Spin up relayer API
relayerConfig := config.NewConfig(config.CreateCosmosCosmosModules(config.CosmosToCosmosConfigInfo{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know this is from the library, still, CosmosCosmos reads weird. Especially when the parameter it takes is called CosmosToCosmosConfidInfo

@gjermundgaraba gjermundgaraba marked this pull request as draft July 14, 2025 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants