-
Notifications
You must be signed in to change notification settings - Fork 307
chore: remove redundant words #1113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: houpo-bob <[email protected]>
WalkthroughThis update corrects typographical errors in comments, documentation, and log messages across three files. No code logic, control flow, or public interfaces are affected. All changes are limited to textual corrections for clarity and accuracy. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
Note ⚡️ Unit Test Generation is now available in beta!Learn more here, or try it out under "Finishing Touches" below. ✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
batch_test.go (1)
43-43
: Minor wording nit – pluralisationThe phrase “each entries” is ungrammatical. Consider singularising:
- // we'll try to commit 10MBs (1000 * 10KBs each entries) of data into the db + // we'll try to commit 10 MB (1 000 entries × 10 KB each) of data into the DBnodedb.go (1)
467-467
: Grammar nit in log messageThe expression “moving on the next version” is missing “to”. Suggest:
- ndb.logger.Error("Error while pruning, moving on the next version in the store", "version missing", version, "next version", version+1, "err", err) + ndb.logger.Error("Error while pruning, moving on to the next version in the store", "version missing", version, "next version", version+1, "err", err)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
batch_test.go
(1 hunks)cmd/iaviewer/README.md
(1 hunks)nodedb.go
(1 hunks)
🔇 Additional comments (1)
cmd/iaviewer/README.md (1)
45-45
: Typo correction acknowledgedThe redundant word has been removed; the sentence now reads clearly.
friendly notice~ |
remove redundant words
Summary by CodeRabbit
Documentation
Style