-
Notifications
You must be signed in to change notification settings - Fork 304
fix: Update GitHub Actions #1108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
WalkthroughThe GitHub Actions workflows for benchmarks and continuous integration were updated to use version 5 of the Changes
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
.github/workflows/ci.yml (1)
12-12
: Pin the action to a specific commit SHA to harden the workflowUsing a moving tag (
actions/checkout@v5
) leaves you vulnerable to a compromised upstream release. GitHub recommends pinning third-party actions to a full commit hash instead:- - uses: actions/checkout@v5 + - uses: actions/checkout@v5 + # Pin for supply-chain safety – replace with the latest v5 SHA + # - uses: actions/[email protected] # exampleAlso verify your self-hosted (if any) runners have Node 20, as
checkout@v5
runs on the Node 20 runtime..github/workflows/benchmarks.yml (1)
14-14
: Repeat the security hardening hereSame remark: pin
actions/checkout@v5
to a commit SHA to avoid supply-chain risk and ensure reproducible builds.- - uses: actions/checkout@v5 + - uses: actions/checkout@v5 + # Consider pinning: actions/[email protected] (or explicit SHA)
Description
actions/checkout
step fromv4
tov5
.Summary by CodeRabbit