fix(sqlite): add forgotten initialisation in sqlite init

[aztecEagle22]

Description

SqliteDb.init makes two existence tests:

1. Does the tree table root exist?
2. Does the leaf table leaf exist?

The second one copied the result of hasRow of the first due to since no Step() call on the second prepared statement was issued.

Summary by CodeRabbit

• Bug Fixes
  • Improved error handling and correctness during database initialization to ensure proper detection of existing tables.

[coderabbitai]

Walkthrough

The update modifies the initialization logic in the SqliteDb struct's init() method, specifically for checking the existence of the leaf table. The revised code explicitly calls the Step() method on the prepared statement to advance the cursor and detect whether any rows are present. Errors from this operation are now handled and returned. This change ensures accurate detection of the table's presence before proceeding with its creation and related schema setup, thereby improving the reliability of the initialization process.

Changes

File(s)	Change Summary
v2/sqlite.go	Added explicit handling of the result from Step() when checking for the leaf table's existence in the init() method, with improved error detection and control flow during database initialization.

Poem

In the warren of code, a table to find,
Now the rabbit steps forward, no row left behind.
With careful detection, errors in sight,
The schema emerges, all handled just right.
Hop, skip, and jump—initialization anew,
The database garden grows sturdy and true!
🐇🌱

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 49c26d6 and f8eebcf.

📒 Files selected for processing (1)

• v2/sqlite.go (1 hunks)

🔇 Additional comments (1)

v2/sqlite.go (1)

209-212: Excellent fix to properly check for leaf table existence.

The added code correctly implements the missing Step() call to execute the prepared statement for checking if the leaf table exists. Without this call, the query wasn't actually being executed, and the code was likely reusing the result from the previous check on the root table. This could lead to incorrect behavior during database initialization.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[aljo242]

is there a way you could add a test to check the validity of this and prevent reversions?