fix: mempool error causes state machine failure #24898

yihuang · 2025-06-24T23:39:14Z

Description

mempool can be configured differently by different nodes, bringing mempool error into state machine can introduce consensus failure (app hash mismatch).

Ideally, mempool should runs in it's own thread, re-consolidate with latest chain tip asynchronously.

Summary by CodeRabbit

Bug Fixes
- Improved error handling to ensure that mempool errors are not treated as state machine execution failures.

Solution: - mempool can be configured differently by different nodes, bringing mempool error into state machine can introduce consensus failure (app hash mismatch).

CHANGELOG.md

coderabbitai · 2025-06-24T23:40:52Z

📝 Walkthrough

Walkthrough

A bug fix was documented in the changelog for the baseapp component, clarifying that mempool errors should not be treated as state machine execution failures. In the code, error handling in BaseApp.runTx was updated to log mempool removal errors instead of returning them, allowing execution to proceed.

Changes

File(s)	Change Summary
CHANGELOG.md	Added a bug fix entry under "Unreleased" for `baseapp`, clarifying mempool error handling.
baseapp/baseapp.go	Modified `runTx` to log errors from mempool removal instead of returning, except for not-found errors.

Sequence Diagram(s)

sequenceDiagram
    participant Client
    participant BaseApp
    participant Mempool
    participant Logger

    Client->>BaseApp: Submit transaction (runTx)
    BaseApp->>Mempool: Remove(tx) during execModeFinalize
    alt Mempool returns ErrTxNotFound
        BaseApp->>BaseApp: Continue execution
    else Mempool returns other error
        BaseApp->>Logger: Log error (do not return)
        BaseApp->>BaseApp: Continue execution
    end
    BaseApp-->>Client: Return result

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Knowledge Base: Disabled due to Reviews > Disable Knowledge Base setting

📥 Commits

Reviewing files that changed from the base of the PR and between da39d1b and 867b967.

📒 Files selected for processing (2)

CHANGELOG.md (1 hunks)
baseapp/baseapp.go (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (1)

GitHub Check: Summary

🔇 Additional comments (1)

baseapp/baseapp.go (1)

888-892: LGTM - Excellent fix for consensus stability.

This change correctly addresses the core issue where mempool errors were causing state machine execution failures. The fix is well-designed:

Consensus safety: Mempool state differences across nodes no longer cause consensus failures

Proper error handling: Errors are still logged for observability but don't interrupt transaction execution

Minimal scope: Only affects mempool removal errors, preserving existing logic for transaction validation

Correct condition: Maintains the existing behavior for ErrTxNotFound which is expected and not an error

The change ensures that during execModeFinalize, transaction execution proceeds regardless of mempool state inconsistencies, which is the correct behavior since the mempool is not part of consensus state.

✨ Finishing Touches

📝 Generate Docstrings

🧪 Generate Unit Tests

Create PR with Unit Tests
Post Copyable Unit Tests in Comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

‼️ IMPORTANT
Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai auto-generate unit tests to generate unit tests for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

aljo242 · 2025-07-15T21:36:44Z

@yihuang can you add a test for this scenario and illustrate how this state could arise more?

fix: mempool error causes state machine failure

8401de2

Solution: - mempool can be configured differently by different nodes, bringing mempool error into state machine can introduce consensus failure (app hash mismatch).

github-project-automation bot added this to Interchain Public Works Jun 24, 2025

yihuang commented Jun 24, 2025

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

Update CHANGELOG.md

867b967

yihuang mentioned this pull request Jun 24, 2025

fix: enforce use of noop mempool MANTRA-Chain/mantrachain#357

Merged

Merge branch 'main' into mempool-error

a24bb3e

Alex | Interchain Labs and others added 2 commits July 28, 2025 13:57

Merge branch 'main' into mempool-error

cb0be08

Merge branch 'main' into mempool-error

e33c4dd

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: mempool error causes state machine failure #24898

fix: mempool error causes state machine failure #24898

Uh oh!

yihuang commented Jun 24, 2025 •

edited

Loading

Uh oh!

Uh oh!

coderabbitai bot commented Jun 24, 2025 •

edited

Loading

Walkthrough

Changes

Sequence Diagram(s)

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

aljo242 commented Jul 15, 2025

Uh oh!

Uh oh!

fix: mempool error causes state machine failure #24898

Are you sure you want to change the base?

fix: mempool error causes state machine failure #24898

Uh oh!

Conversation

yihuang commented Jun 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Summary by CodeRabbit

Uh oh!

Uh oh!

coderabbitai bot commented Jun 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Sequence Diagram(s)

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

aljo242 commented Jul 15, 2025

Uh oh!

Uh oh!

yihuang commented Jun 24, 2025 •

edited

Loading

coderabbitai bot commented Jun 24, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)