-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cosmos-sdk-proto: update tonic to 0.11 #460
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It would be helpful to publish a new cosmos-sdk-proto release. Would you like me to update the versions in this PR? |
Minimise lockfile changes
I can minimise the lockfile changes, if that helps. Though testing the lib with an old snapshot of historic dependencies is perhaps not ideal. |
My dependencies would also greatly benefit if this could get merged |
kent-3
added a commit
to kent-3/cosmos-rust
that referenced
this pull request
Apr 15, 2024
* cosmrs: expose `base::query` module and pagination types (cosmos#454) * cosmos-sdk-proto: add more IBC related names (cosmos#457) * cosmrs: added support for validator-related queries in staking module (cosmos#453) * correctly populate 'updated' and 'msg' fields from proto responses (cosmos#451) * cosmos-sdk-proto: update tonic to 0.11 (cosmos#460) Minimise lockfile changes * Bump tendermint-rs dependencies to v0.35 (cosmos#461) * cosmos-sdk-proto: use `prost-build` to gen IBC `Name` impls (cosmos#462) Uses the recently added support in `prost-build` for automatically generating impls of the `Name` trait for IBC-related types, rather than maintaining them by hand in the `type_names` module. Unfortunately we can only do this for the IBC protos, since we build the others using `buf`. * cosmos-sdk-proto v0.21.0 (cosmos#463) * cosmrs v0.16.0 (cosmos#464) * cosmos-sdk-proto: remove deprecated `MessageExt` methods (cosmos#465) * cosmos-sdk-proto v0.21.1 (cosmos#466) --------- Co-authored-by: Jędrzej Stuczyński <[email protected]> Co-authored-by: Fabien Penso <[email protected]> Co-authored-by: Alex Butler <[email protected]> Co-authored-by: Tony Arcieri (iqlusion) <[email protected]>
kent-3
added a commit
to kent-3/cosmos-rust
that referenced
this pull request
Apr 15, 2024
* cosmrs: expose `base::query` module and pagination types (cosmos#454) * cosmos-sdk-proto: add more IBC related names (cosmos#457) * cosmrs: added support for validator-related queries in staking module (cosmos#453) * correctly populate 'updated' and 'msg' fields from proto responses (cosmos#451) * cosmos-sdk-proto: update tonic to 0.11 (cosmos#460) Minimise lockfile changes * Bump tendermint-rs dependencies to v0.35 (cosmos#461) * cosmos-sdk-proto: use `prost-build` to gen IBC `Name` impls (cosmos#462) Uses the recently added support in `prost-build` for automatically generating impls of the `Name` trait for IBC-related types, rather than maintaining them by hand in the `type_names` module. Unfortunately we can only do this for the IBC protos, since we build the others using `buf`. * cosmos-sdk-proto v0.21.0 (cosmos#463) * cosmrs v0.16.0 (cosmos#464) * cosmos-sdk-proto: remove deprecated `MessageExt` methods (cosmos#465) * cosmos-sdk-proto v0.21.1 (cosmos#466) --------- Co-authored-by: Jędrzej Stuczyński <[email protected]> Co-authored-by: Fabien Penso <[email protected]> Co-authored-by: Alex Butler <[email protected]> Co-authored-by: Tony Arcieri (iqlusion) <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tonic
to v0.11This is a breaking change to cosmos-sdk-proto.