Milestone 8 - Crafting #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sam Biggins <[email protected]>
* feat: add help screen Signed-off-by: Sam Biggins <[email protected]> * feat: add help screen tip Signed-off-by: Sam Biggins <[email protected]> * refactor: move time feature files to correct subfolders Signed-off-by: Sam Biggins <[email protected]> * fix: slow and pause time events Signed-off-by: Sam Biggins <[email protected]> --------- Signed-off-by: Sam Biggins <[email protected]>
* feat: add hammer item/asset * fix(focus): correctly handle player moving out of range of focus objects Signed-off-by: Sam Biggins <[email protected]> * refactor: make hammer pickupable, modify world position Signed-off-by: Sam Biggins <[email protected]> * refactor(focus): refactor focusSystem to focusManager class Signed-off-by: Sam Biggins <[email protected]> * fix(focus): correctly center focus arrow Signed-off-by: Sam Biggins <[email protected]> * feat(controls): add simple onClick function for initial mouse handling Signed-off-by: Sam Biggins <[email protected]> * chore: remove extraneous logging Signed-off-by: Sam Biggins <[email protected]> * refactor: move all focus functionality to entity feature Signed-off-by: Sam Biggins <[email protected]> * refactor(focus): calculate distance based on nearest edges Signed-off-by: Sam Biggins <[email protected]> --------- Signed-off-by: Sam Biggins <[email protected]>
* feat: implement simple crafting Signed-off-by: Sam Biggins <[email protected]> * feat(crafting): add recipes, rock item and assets Signed-off-by: Sam Biggins <[email protected]> * fix: add missing eslint plugin Signed-off-by: Sam Biggins <[email protected]> * refactor(crafting): remove code smells Signed-off-by: Sam Biggins <[email protected]> --------- Signed-off-by: Sam Biggins <[email protected]>
Signed-off-by: Sam Biggins <[email protected]>
Signed-off-by: Sam Biggins <[email protected]>
Signed-off-by: Sam Biggins <[email protected]>
* feat: add help screen Signed-off-by: Sam Biggins <[email protected]> * feat: add help screen tip Signed-off-by: Sam Biggins <[email protected]> * refactor: move time feature files to correct subfolders Signed-off-by: Sam Biggins <[email protected]> * fix: slow and pause time events Signed-off-by: Sam Biggins <[email protected]> --------- Signed-off-by: Sam Biggins <[email protected]>
* feat: add hammer item/asset * fix(focus): correctly handle player moving out of range of focus objects Signed-off-by: Sam Biggins <[email protected]> * refactor: make hammer pickupable, modify world position Signed-off-by: Sam Biggins <[email protected]> * refactor(focus): refactor focusSystem to focusManager class Signed-off-by: Sam Biggins <[email protected]> * fix(focus): correctly center focus arrow Signed-off-by: Sam Biggins <[email protected]> * feat(controls): add simple onClick function for initial mouse handling Signed-off-by: Sam Biggins <[email protected]> * chore: remove extraneous logging Signed-off-by: Sam Biggins <[email protected]> * refactor: move all focus functionality to entity feature Signed-off-by: Sam Biggins <[email protected]> * refactor(focus): calculate distance based on nearest edges Signed-off-by: Sam Biggins <[email protected]> --------- Signed-off-by: Sam Biggins <[email protected]>
* feat: implement simple crafting Signed-off-by: Sam Biggins <[email protected]> * feat(crafting): add recipes, rock item and assets Signed-off-by: Sam Biggins <[email protected]> * fix: add missing eslint plugin Signed-off-by: Sam Biggins <[email protected]> * refactor(crafting): remove code smells Signed-off-by: Sam Biggins <[email protected]> --------- Signed-off-by: Sam Biggins <[email protected]>
# Conflicts: # .github/workflows/code-quality.yaml
* feat(crafting): implement crafting ui Signed-off-by: Sam Biggins <[email protected]> * feat(crafting): make crafting scene (window) draggable Signed-off-by: Sam Biggins <[email protected]> * fix(crafting): fix duplicate call to craft function * refactor(crafting): rename to craftingScene, break code in to additional methods for clarity * feat(crafting): implement crafting ui Signed-off-by: Sam Biggins <[email protected]> * feat(crafting): make crafting scene (window) draggable Signed-off-by: Sam Biggins <[email protected]> * fix(crafting): fix duplicate call to craft function * refactor(crafting): rename to craftingScene, break code in to additional methods for clarity * refactor(entity): create common draggable class, inherit subscenes from it Signed-off-by: Sam Biggins <[email protected]> * refactor(entity): simplify all subscenes to be uniform Signed-off-by: Sam Biggins <[email protected]> * refactor(entity): add location contants for subscenes, colorize recipe text based craftability Signed-off-by: Sam Biggins <[email protected]> --------- Signed-off-by: Sam Biggins <[email protected]>
|
Kudos, SonarCloud Quality Gate passed!
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -9,11 +10,10 @@ | |||
| this.add.image(400, 300, 'starry_night'); | |||
|
|
|||
| const forestSilhouette = this.add.image(400, 300, 'forest_silhouette'); | |||
| forestSilhouette.setScale(1); | |||
| forestSilhouette.setScale(1).setDepth(10); | |||
Check warning
Code scanning / QDJS
Void function return value used Warning
|
|
||
| const title = this.add.image(400, 150, 'postapoc_title'); | ||
| title.setScale(2); | ||
|
|
||
| title.setScale(2).setDepth(10); |
Check warning
Code scanning / QDJS
Void function return value used Warning
|
|
||
| export default class HelpScene extends DraggableScene { | ||
| protected logger = getLogger('entity'); | ||
| private controlMapping: ControlMapping; |
Check notice
Code scanning / QDJS
Field can be readonly Note
| this.cameras.main.height, | ||
| 'mushroom_cloud' | ||
| ); | ||
| mushroomCloud.setScale(0.1).setOrigin(0.5, 1); |
Check warning
Code scanning / QDJS
Void function return value used Warning
smileynet
requested review from
github-advanced-security[bot]
and removed request for
github-advanced-security[bot]
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.