Improve streaming on MetricsForLabelMatchersStream method #6436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: alanprot <[email protected]>
SungJin1212
reviewed
Dec 18, 2024
Co-authored-by: SungJin1212 <[email protected]> Signed-off-by: Alan Protasio <[email protected]>
SungJin1212
approved these changes
Dec 18, 2024
|
Would it come up in a benchmark like https://github.com/cortexproject/cortex/blob/master/pkg/ingester/ingester_test.go#L3109? |
That benchmark is not using the Stream method.. but i can try to make it use. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Currently, the
MetricsForLabelMatchersStreamaccumulates all result series in memory before starts streaming.The PR changes to stream series as soon as the batch size is reached.
Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]