Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compatibility query fuzz test with results cache enabled #6313

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

yeya24
Copy link
Contributor

@yeya24 yeya24 commented Nov 5, 2024

What this PR does:

Existing query fuzz tests don't enable results cache.

This PR adds a new query fuzz test focusing on catching results cache compatibility issue.

The workflow is like follows:

  1. Run two Cortex containers with previous image and latest image. They share the same result cache.
  2. Run a range query with time [start, start + 30m] against a Cortex container with previous release image to fill results cache.
  3. Run the same range query with time [start, end] against a Cortex container with the latest image.
  4. Run the same range query with time [start, end] but with results cache bypassed and compare the query result got from last step.

The test is a bit overlapped with the existing query result compatibility test because compatibility issue also cause results cache to go wrong. But it also catches changes of the result cache itself. For example, #6196

Which issue(s) this PR fixes:
Fixes #

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

Signed-off-by: Ben Ye <[email protected]>
Copy link
Member

@alanprot alanprot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks..
The more the merrier :D

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 6, 2024
Signed-off-by: Ben Ye <[email protected]>
Signed-off-by: Ben Ye <[email protected]>
Signed-off-by: Ben Ye <[email protected]>
Signed-off-by: Ben Ye <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants