feat: CET-5075 add missing fields in ProjectApprovalsConfig #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 58438c6)
aszarama
requested review from
maddymanu,
cristinabuenahora,
gsdatta and
greg-p-cortex
|
LGTM |
cristinabuenahora
approved these changes
Jan 10, 2024
greg-p-cortex
approved these changes
Jan 11, 2024
Yep, they don't exist without an Ultimate account so we should be able to validate that ourselves. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira ticket: https://cortex1.atlassian.net/browse/CET-5075
This PR adds two missing fields from ProjectApprovalsConfig and bumps version of the client to 6.0.3.
Missing fields where cherry-picked from upstream.
Link to PR that needs these changes: https://github.com/cortexapps/brain-backend/pull/4867