Draft: (partial) fix for 'ce.declare' with SymbolDefinition using prop. 'type' #226
+26
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samueltlg
commented
Dec 23, 2024
| !( | ||
| (typeof def.type === 'string' && isSubtype(def.type, 'function')) || | ||
| (def.type && isValidType(def.type)) | ||
| ) |
There was a problem hiding this comment.
Think this was a bug/typo? I.e. final cond. to be negated.
samueltlg
commented
Dec 23, 2024
| throw new Error( | ||
| 'The `type` field of a symbol definition should be of type `string`' | ||
| ); | ||
| } |
There was a problem hiding this comment.
Think that's OK; but some introduced errs. may be surfacing on account of type being given as undefined: so may require minor adjstment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed that
ce.declareerrors when supplying a SymbolDefinition of form{type: TypeString}for second arg.Current changes appear to address the issue, but appears to surface or reveal a few existing test errs. where throughout these, type values given through 'SymbolDefinition.type' do not conform to current type definitions: e.g.
{ type: 'set<integers>', ... }is given whereas in this context, according to definition of the type 'Type', a{kind: 'set', elements: 'integers' }is expected instead. Did try to investigate further but opened a bit of a can of worms.Believe that almost all errs. can be addressed fairly easily with present changes, but may require some alterations.
For reference, for the commit at which this was branched, 4 'snapshot' errors were already present split between tests 'compute-engine/compile.test.ts', and 'compute-engine/compile.test.ts'. This change surfaces ~18 newer. Feel free to edit as pleased or denounce changes