correct transition locations when a device is rotated#9
Open
mdsandell wants to merge 1 commit intocoronalabs:masterfrom
Open
correct transition locations when a device is rotated#9mdsandell wants to merge 1 commit intocoronalabs:masterfrom
mdsandell wants to merge 1 commit intocoronalabs:masterfrom
Conversation
Signed-off-by: Mark Sandell <mdsandell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a device is rotated, composer transition effects like zoomOutIn originate in the wrong location. This corrects that by simply redefining the effects if/when the device is rotated.
PS: Since this change indents the effectsList (which is really large and makes the standard diff look horrible), append ?w=1 to the URL (e.g.
https://github.com/coronalabs/framework-composer/pull/9/files?w=1)