Add AdMob UMP/CMP API code examples & gotchas#168
Open
XeduR wants to merge 3 commits intocoronalabs:masterfrom
Open
Add AdMob UMP/CMP API code examples & gotchas#168XeduR wants to merge 3 commits intocoronalabs:masterfrom
XeduR wants to merge 3 commits intocoronalabs:masterfrom
Conversation
Atom was officially discontinued by Microsoft/GitHub in December 2022 and so it shouldn't be recommended as a viable editor in the docs.
The current documentation pages are incomplete and lack valuable information on how to properly use the new AdMob UMP/CMP API.
- Like the documentation states, appId is no longer set via admob.init(), but it gets read from build.settings for iOS & Android. - Adding the testMode init parameter just in case in the example code
Contributor
Author
|
Colin reminded me on the forums of how appId has not been set via |
Contributor
Author
|
@scottrules44 Could you check if these rewritten and extended AdMob UMP/CMP documentation pages are up to par? One thought that crossed my mind was adding a mention somewhere that the message needs to also be set up over at AdMob's portal. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current documentation pages are incomplete and lack valuable information on how to properly use the new AdMob UMP/CMP API.
This topic has been discussed in detail over at the forums: https://forums.solar2d.com/t/new-requirements-from-google-to-show-ads-cmp/355707. If there are further improvements that someone things could be made, feel free to add to or modify the pages further.