Incorporate minor updates from the standard library #26
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
Migrating this over from: spf13#353
Figured you might be interested in it.
While reading the source for this pkg, I noticed the usage of
bytes.Buffer
in places where Go 1.10'sstrings.Builder
could be used instead.(It's intended for this and should be marginally more performant by avoiding some copies internally)
While migrating over, I found a handful of other small linting changes that seem acceptable.
All that is included here, but anything can be dropped if it's not desired.
I don't expect this to change any of observable behavior and the tests pass, but who knows.
Extra text not in the original PR:
I might have to rebase this if you don't want to pull in the missing commit from their master as well.
Also 2433e5b is likely better than no up-front allocation, but still isn't the exact size.
So I'm only guessing that this does less reallocs than it did before, but probably has to do at least 1.
We can either try to improve this logic or just drop it.
The commits are split up for review but can get squashed or something too.
Checklist
N/A
make test
has been rungo test .\...
was used instead and passes.Cobra is thus not tested with this.
make lint
has been runThere are some
gofmt
issues, but they're not introduced by me.