Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated the CLUT lookup for the 4 channel color image pixel data for correct pseudo coloring and rendering #545

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

Trenser-SandeepNayathil
Copy link

@Trenser-SandeepNayathil Trenser-SandeepNayathil commented Sep 2, 2021

Below are the summary of the updates to correct the pseudo coloring of 4 channel data similar to the issue reported in #463

  1. Updated the CLUT lookup for the 4 channel color image pixel data for correct pseudo coloring and rendering as below
    • Calculate the relative luminance from RGB linear components of each pixel(4 byte).
    • Skipping the Alpha channel
    • Handle similarly for the minimum pixel value -ve and 0 or above scenarios
  2. Modifications in "storedPixelDataToCanvasImageDataPseudocolorLUT" done by following the same way as existing similar functions with separate handling of the minimum pixel value scenarios.
  3. Added unit test for the updates in "storedPixelDataToCanvasImageDataPseudocolorLUT" for the 4 byte color image CLUT lookup.

@Trenser-SandeepNayathil
Copy link
Author

Trenser-SandeepNayathil commented Nov 29, 2021

Hi @swederik,
Could you please review the updates?
Also, as part of this update some checks found to be failed in it. Could you please suggest how to fix those deploy and CircleCI test issues.
Thanks In Advance..

@andydoe19
Copy link

Helloo @Trenser-SandeepNayathil @swederik , has this issue finally been fixed? Cos am unable to apply colormap to my images loaded with cornerstoneWebImageLoader, and wondering if this could help. If not I'll be glad if anyone can point me in the right direction. Thank you in advance!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants