Remove unused components #140
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
[diff-counting] Significant lines: 5. |
|
Visit the preview URL for this PR (updated for commit 05c8e2e): https://zing-lsc--pr140-component-cleanup-uet77dcw.web.app (expires Sun, 08 Jan 2023 20:39:17 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 1fc18307b178c916e2663810a6932f60b173c01b |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
There are a lot of unused pieces in the frontend that are no longer being used. To reduce the working size of the project as well as make the codebase more neat and straightforward, the components that have been unused and will be unused, either due to deprecation or impracticality, were deleted.
The following were removed:
Test Plan
JetBrains IDEs have a useful "check for references" feature which I used before I deleted something. Also, running the app and having everything working is a good sign that those components are just unused.
Notes
In a future pull request, there will be slight refactoring of the codebase so that components are in the right location and minimal styled components are used (as opposed to excessively).