Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes linter issues and simplifies implementation #28

Merged
merged 26 commits into from
Sep 8, 2023
Merged

Fixes linter issues and simplifies implementation #28

merged 26 commits into from
Sep 8, 2023

Conversation

mscottford
Copy link
Member

@mscottford
Adds bin/format.rb
0e0692a
@mscottford
Applies the results of running bin/format.rb
20b2747
@mscottford
Normalizes file
c3e4cff
@mscottford
Fixes indentation and wrapping
abe7f26
@mscottford
Addresses indentation issue
4208a81
@mscottford
Avoids null exceptions
d31b312
@mscottford
Adds scenario for BOM generation failure
56e2392
@mscottford
Fixes some linter issues and failing tests
7e1a1d4
@mscottford
Fixes misconfiguration with NUnit and xUnit
3c61627
@mscottford
Upgrades freshli-commons to v0.6.10
724e975
@mscottford
Returns path to an isolated fixture file
a988cc1 
Fixture file modifications by some of the tests are causing them to sometimes fail depending on the order that the tests are run in.

This copies the entire fixtures directory tree to a temp location, and then returns a path to the newly created temp file version of the requested file.
@mscottford
Simplifies implementation
4ad40ff 
As part of cleaning up linter errors, a lot of classes that were not being used have been removed. Others that remained have been simplified by removing assumptions that were left over from the Freshli.Lib project that they originated from.
@mscottford
Removes commands other than start-server
033ccd9 
The other commands are not needed, because the Freshli CLI only interacts with the language agent via gRPC calls.
@mscottford
Ensures that root directory is searched
266cf42
@mscottford
Avoids reliance on number of responses
c036071
@mscottford
Switches to round-trip DateTimeOffset format
89d1a66
@mscottford
Attempting to figure out which test is hanging
04a377a
@mscottford
Attempting to determine with test is hanging in CI
5a72bab
@mscottford
Attempting to determine which test is hanging in CI
7b8b8e1
@mscottford
Re-enabling some tests to see if things stop hanging
267a3a2
@mscottford
More troubleshooting of hanging tests
6daf6b5
@mscottford
Adds diagnostic test runner to help track down hanging tests
4ea206e
@mscottford
Re-enables all tests
65cd6c3
@mscottford
Addresses linter issues
9b1947c
@mscottford
Turns on linting as part of CI
b485a0b
@mscottford
Ensures that eclint is installed
4763735
@mscottford mscottford merged commit 20ea04c into main Sep 8, 2023
1 check passed
@mscottford mscottford deleted the linter-fixes branch September 8, 2023 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Address linter issues Build out linter integration
1 participant
@mscottford