Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd-diff: support passing in the architecture #3999

Merged
merged 1 commit into from
Jan 17, 2025
Merged

cmd-diff: support passing in the architecture #3999

merged 1 commit into from
Jan 17, 2025

Conversation

nikita-dubrovskii
Copy link
Contributor

This adds '--arch' argument to pass architecture you want to get information about. By default current arch is used.

$ uname -m
x86_64
$ cosa diff --arch=s390x --from=41.20250101.20.0 --to=41.20250114.20.0 --rpms
ostree diff commit from: c3fe29653cf0ebd1d093b1a55cf9ac79a386373e71f64c67769f904332ba0ca6
ostree diff commit to:   988aa49471f406354274bc013c1102004dad25000862df68472d6058fcb00f8b
Upgraded:
  audit 4.0.2-1.fc41 -> 4.0.3-1.fc41
  audit-libs 4.0.2-1.fc41 -> 4.0.3-1.fc41
  ...

Issue: #3987

dustymabe
dustymabe approved these changes Jan 16, 2025
View reviewed changes
Copy link
Member

@dustymabe dustymabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jlebon jlebon enabled auto-merge (rebase) January 16, 2025 21:45
@nikita-dubrovskii
cmd-diff: support passing in the architecture
eef70a3 
This adds '--arch' argument to pass architecture you want to get information about.
By default current arch is used.

```
$ uname -m
x86_64
$ cosa diff --arch=s390x --from=41.20250101.20.0 --to=41.20250114.20.0 --rpms
ostree diff commit from: c3fe29653cf0ebd1d093b1a55cf9ac79a386373e71f64c67769f904332ba0ca6
ostree diff commit to:   988aa49471f406354274bc013c1102004dad25000862df68472d6058fcb00f8b
Upgraded:
  audit 4.0.2-1.fc41 -> 4.0.3-1.fc41
  audit-libs 4.0.2-1.fc41 -> 4.0.3-1.fc41
  ...
```

Issue: coreos#3987
@jlebon jlebon merged commit 41c6b42 into coreos:main Jan 17, 2025
5 checks passed
@nikita-dubrovskii nikita-dubrovskii deleted the issue-3987 branch January 17, 2025 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlebon jlebon jlebon approved these changes

@dustymabe dustymabe dustymabe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nikita-dubrovskii @dustymabe @jlebon