create_disk: update grub2-install invocation to match bootupd #3699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bootupd calls grub2-install with mdraid1x and part_gpt [1]. We are updating our grub2-install test to match what bootupd is doing for the grub2-install verification [2]. Let's also update create_disk.sh here so the test will pass regardless of whether a disk image was created with create_disk.sh or osbuild (which currently will use bootupd for the bootloader install). [1] https://github.com/coreos/bootupd/blob/e1be3005d827fc3bacf82a2c2a98cd9c0706c65f/src/bios.rs#L66-L69 [2] coreos/fedora-coreos-config#2810
|
We'll probably have to merge this one without passing tests because this one and coreos/fedora-coreos-config#2810 are tightly coupled. |
|
@dustymabe: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
Closing this as we updated the strategy here as suggested in coreos/fedora-coreos-config#2810 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bootupd calls grub2-install with mdraid1x and part_gpt [1]. We are updating our grub2-install test to match what bootupd is doing for the grub2-install verification [2]. Let's also update create_disk.sh here so the test will pass regardless of whether a disk image was created with create_disk.sh or osbuild (which currently will use bootupd for the bootloader install).
[1] https://github.com/coreos/bootupd/blob/e1be3005d827fc3bacf82a2c2a98cd9c0706c65f/src/bios.rs#L66-L69
[2] coreos/fedora-coreos-config#2810