osbuild: bump to osbuild v100 #3671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumping to v100 lets us drop 0001-stages-add-kernel-cmdline.bls-append-stage.patch Here we also update the size calculation patch to match what was merged in osbuild/osbuild#1453
Let's define the partitioning for the input mpp yaml here in a more human friendly way using GiB and MiB terms. This yields no change in the generated json.
This will make the partitions get a partition label, which we rely on. See coreos/fedora-coreos-config#2704 (comment)
|
Can we freeze on the osbuild version while we're carrying patches? |
I guess we could, but I'm adding new patches often and also wanting to pull in some updates so I don't mind keeping it updated. In my next addition or removal of a patch I'll freeze it (i.e. not in this one, but the next) if you like? |
jlebon
approved these changes
Nov 28, 2023
Yeah, I think the way this should probably work is we freeze and then in the same PR we can atomically update the patches and the freeze. I'll add it to #3667 since I'll have to rebase anyway for review comments. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also update the osbuild input definition to be more human friendly and add partition labels.